[PATCH] [RFC] net: smc911x: Drop the standalone EEPROM example

Marek Vasut marek.vasut at gmail.com
Tue Mar 17 19:23:07 CET 2020


On 3/17/20 7:10 PM, Masahiro Yamada wrote:
> On Sun, Mar 15, 2020 at 8:19 AM Marek Vasut <marek.vasut at gmail.com> wrote:
>>
>> Drop the example, for two reasons. First, it is tapping directly into
>> the IO accessors of the SMC911x, while it should instead go through
>> the net device API. Second, this makes conversion of the SMC911x driver
>> to DM real hard.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
>> Cc: Joe Hershberger <joe.hershberger at ni.com>
>> Cc: Tom Rini <trini at konsulko.com>
>> ---
>>  examples/standalone/Makefile         |   1 -
>>  examples/standalone/smc911x_eeprom.c | 379 ---------------------------
>>  2 files changed, 380 deletions(-)
>>  delete mode 100644 examples/standalone/smc911x_eeprom.c
> 
> 
> Yeah, I was disturbed by this example code.
> 
> I agree we should drop it.
> 
> Reviewed-by: Masahiro Yamada <yamada.masahiro at socionext.com>

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even
have U-Boot application API to access DM EEPROM ?

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list