[RFC RFT PATCH] env: spl: filter the variables in default environment of SPL or TPL

Patrick DELAUNAY patrick.delaunay at st.com
Wed Mar 18 16:57:19 CET 2020


Hi Wolfgang,

> From: Wolfgang Denk <wd at denx.de>
> Sent: mercredi 18 mars 2020 15:51
> To: Patrick DELAUNAY <patrick.delaunay at st.com>
> Cc: u-boot at lists.denx.de; Bin Meng <bmeng.cn at gmail.com>; Fabio Estevam
> <festevam at gmail.com>; Heinrich Schuchardt <xypron.glpk at gmx.de>; Jagan
> Teki <jagan at amarulasolutions.com>; Joe Hershberger
> <joe.hershberger at ni.com>; Kever Yang <kever.yang at rock-chips.com>; Marek
> Vasut <marex at denx.de>; Simon Glass <sjg at chromium.org>; U-Boot STM32
> <uboot-stm32 at st-md-mailman.stormreply.com>
> Subject: Re: [RFC RFT PATCH] env: spl: filter the variables in default
> environment of SPL or TPL
> 
> Dear Patrick,
> 
> In message <20200318143602.23253-1-patrick.delaunay at st.com> you wrote:
> > Use a new option CONFIG_SPL_ENV_VARS to filter the variables included
> > in the default environment used in SPL (and TPL).
> >
> > That allows to reduce the size of default_environment[].
> 
> Sorry, but NAK.  we had this discussion a couple of times before.
> It is mandatory that both SPL and U-Boot proper will use the _same_ environment,
> including the same default environment, or all kind of havoc may result.  Just think
> of situations where Falcon Mode is being used and SPL and U-Boot proper would
> be using different settings.
> 
> If your default environment is too big for the SPL, then make it smaller.  If you
> need additional settings in U-Boot, there are many ways to load thise there.

Thanks for the answer, 
so it was clearly not an option and I abandon this patch.

To complete my answer, today I don't have issue with SPL environment size on the stm32 targets,

I propose this patch only to solve issue with my previous proposed patch on other target

- [U-Boot,v4,3/3] env: Add CONFIG_ENV_FULL_SUPPORT
- [U-Boot,v4,2/3] env: introduce macro ENV_IS_IN_SOMEWHERE

This proposal raise many size issue for other boards when I activated
CONFIG_SPL_ENV_SUPPORT and CONFIG_SPL_ENV_IS_NOWHERE by default....

Today I don’t see solution except accept the current situation:
for some target, the environment isn't supported/activated in SPL, even default one
(when CONFIG_SPL_ENV_SUPPORT not activated, the env source files aren't compiled)

So I will also abandon the previous patchset
- http://patchwork.ozlabs.org/patch/1171180/ 
- http://patchwork.ozlabs.org/patch/1171098/

Patrick

> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "If
> that makes any sense to you, you have a big problem."
>                                   -- C. Durance, Computer Science 234


More information about the U-Boot mailing list