Antwort: [PATCH v2 33/39] acpi: Add support for SSDT generation

[Wolfgang Wallner]

Hi Simon,

"Simon Glass" <sjg at chromium.org> schrieb am 09.03.2020 04:44:57:

> Betreff: [PATCH v2 33/39] acpi: Add support for SSDT generation
> 
> Some devices need to generate code for the Secondary System Descriptor
> Table (SSDT). Add a method to handle this.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> Changes in v2:
> - Switch parameter order of _acpi_fill_ssdt() and make it static
> 
>  arch/sandbox/dts/test.dts |  2 ++
>  drivers/core/acpi.c       | 14 +++++++++++++
>  include/dm/acpi.h         | 23 ++++++++++++++++++++++
>  test/dm/acpi.c            | 41 ++++++++++++++++++++++++++++++++++++++-
>  4 files changed, 79 insertions(+), 1 deletion(-)
> 

[snip]

> diff --git a/test/dm/acpi.c b/test/dm/acpi.c
> index feb380b26c..305d8395ff 100644
> --- a/test/dm/acpi.c
> +++ b/test/dm/acpi.c
> @@ -7,6 +7,7 @@

[snip]

>  static const struct udevice_id testacpi_ids[] = {
> @@ -313,3 +325,30 @@ static int dm_test_acpi_cmd_dump(struct 
unit_test_state *uts)
>     return 0;
>  }
>  DM_TEST(dm_test_acpi_cmd_dump, DM_TESTF_SCAN_PDATA | 
DM_TESTF_SCAN_FDT);
> +
> +/* Test acpi_fill_ssdt() */
> +static int dm_test_acpi_fill_ssdt(struct unit_test_state *uts)
> +{
> +   struct acpi_ctx ctx;
> +   u8 *buf;
> +
> +   buf = malloc(BUF_SIZE);
> +   ut_assertnonnull(buf);
> +
> +   ctx.current = buf;
> +   buf[4] = 'z';   /* sentinal */

nit: sentinel ?

> +   ut_assertok(acpi_fill_ssdt(&ctx));
> +
> +   /* These values come from acpi-test's acpi-ssdt-test-data property 
*/
> +   ut_asserteq('a', buf[0]);
> +   ut_asserteq('b', buf[1]);
> +
> +   /* These values come from acpi-test2's acpi-ssdt-test-data property 
*/
> +   ut_asserteq('c', buf[2]);
> +   ut_asserteq('d', buf[3]);
> +
> +   ut_asserteq('z', buf[4]);
> +
> +   return 0;
> +}
> +DM_TEST(dm_test_acpi_fill_ssdt, DM_TESTF_SCAN_PDATA | 
DM_TESTF_SCAN_FDT);
> -- 
> 2.25.1.481.gfbce0eb801-goog
> 

Reviewed-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>