[PATCH 1/2] arm: mvebu: clearfog: add SCSI to distro bootcmd

[Joel Johnson]

As with other related ClearFog patches, I haven't received any review 
responses on this series 
(http://patchwork.ozlabs.org/project/uboot/list/?series=155760) and 
would like to ping out for additional review. I'd especially like 
feedback on the approach for support of multiple SCSI devices, if there 
a preferred or standardized mechanism I'd be happy to adjust, but I 
couldn't find any other examples of including multiple SCSI devices in 
distro_boot. In reviewing again myself there was an initial mental 
mismatch between CON2/CON3 usage as connection ports and the naming of 
SCSI_CLEARFOG2/SCSI_CLEARFOG3 as index counters, but otherwise still 
seems good.

If it's in an acceptable state for inclusion in the next merge window, 
that's certainly fine too, I'm just looking for a crosscheck.

Thanks!
Joel

On 2020-01-28 20:59, Joel Johnson wrote:
> Include attempting to boot from SCSI (SATA) devices within generated
> board distro bootcmd environment. The reasoning for boot ordering is
> that MMC and USB are external and removable, while when a case is in
> use, replacing M.2 or mSATA drives requires disassembly. Therefore,
> to boot SCSI, [bootable] external media must be removed. If SCSI were
> placed before MMC or USB, then removing a bootable SCSI drive to
> enable MMC or USB booting would be more difficult.
> 
> Signed-off-by: Joel Johnson <mrjoel at lixil.net>
> 
> ---
> 
>  include/configs/clearfog.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/configs/clearfog.h b/include/configs/clearfog.h
> index 633187d86f..a452f4b009 100644
> --- a/include/configs/clearfog.h
> +++ b/include/configs/clearfog.h
> @@ -110,9 +110,16 @@
>  #define BOOT_TARGET_DEVICES_USB(func)
>  #endif
> 
> +#ifdef CONFIG_SCSI
> +#define BOOT_TARGET_DEVICES_SCSI(func) func(SCSI, scsi, 0)
> +#else
> +#define BOOT_TARGET_DEVICES_SCSI(func)
> +#endif
> +
>  #define BOOT_TARGET_DEVICES(func) \
>  	BOOT_TARGET_DEVICES_MMC(func) \
>  	BOOT_TARGET_DEVICES_USB(func) \
> +	BOOT_TARGET_DEVICES_SCSI(func) \
>  	func(PXE, pxe, na) \
>  	func(DHCP, dhcp, na)