[RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"

Marek Vasut marex at denx.de
Mon Mar 23 12:46:37 CET 2020

On 3/23/20 7:57 AM, Lukasz Majewski wrote:
> Hi Marek,


>> On 3/22/20 2:00 PM, Lukasz Majewski wrote:
>>> This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6.
>>> Signed-off-by: Lukasz Majewski <lukma at denx.de>  
>> This patch lacks any and all explanation why this is being reverted.
>> The patch you are reverting here explains why it was added and what
>> real issues it was fixing, so instead of reverting it, if there is an
>> issue with that patch, you should identify the issue and fix it.
> Marek, have you received the cover letter for this patch series?
> In the cover letter I've written the rationale for reverting this
> patch. 

That should have been explained in this patch description.

> In short - qhtoken has value of 0x0, when the token variable shows
> errors. As a result the error handling is broken.
> Could you comment on those arguments?

Maybe you are referencing/reading the wrong token ?

You should probably figure out why this doesn't work first and then add
fixes on top.

> Moreover, I've explicitly stated that this is a Request For
> Testing like patch series with a detailed report of testing procedure
> (for my use case) for the USB in U-Boot (as Tom has tested the patch
> with some ETH dongles). 

I was still unable to replicate the ethernet device failure.

Best regards,
Marek Vasut

More information about the U-Boot mailing list