[RFC PATCH 6/9] mkimage_fit_atf.sh: produce working binaries by default

Petr Štetiar ynezz at true.cz
Mon Mar 23 16:24:15 CET 2020

Michal Simek <michal.simek at xilinx.com> [2020-03-23 14:58:55]:


> Plan is to merge all of these to one shell script because most of the
> content in that script is very similar.

to me it all just seems as values and templates hidden inside shell script
called generator.  Each of this generators uses/references 1-N variables, 1-N
out-of-tree dependencies and 1-N DT sections.

So instead of cooking custom shell templating engine I took different
approach[1] and simply removed the shell script generator in favor of Python
based templating engine, allowing for ITS dependency tracking and values
directly in Make.

Lets see what is preferred.

> The issue which I see is that patch above is changing current behavior
> which means when this is applied all travis/gitlab/azure jobs will fail
> because none has setup this config option.

If that is desired, then in order to keep the current behavior, I see
following options:

 1. Disable building of boards having out-of-tree dependencies on build bot/CI
 2. Enable BUILDBOT_BROKEN_BINARIES=y by default
 3. Add detection of various build bot/CI platforms and enable
    BUILDBOT_BROKEN_BINARIES=y by default, which then could cause further issues
    when one would actually run test the binaries from build bot/CI
 4. Include the out-of-tree dependencies (unlikely)

What is your suggestion?

1. https://patchwork.ozlabs.org/project/uboot/list/?series=166092



More information about the U-Boot mailing list