[PATCH] net: macb: Fix incorrect write function name when MACB_ZYNQ is enabled.

Michal Simek michal.simek at xilinx.com
Thu Mar 26 15:01:29 CET 2020

When MACB_ZYNQ is enabled there is compilation warnings
drivers/net/macb.c: In function ‘_macb_init’:
drivers/net/macb.h:675:33: error: ‘MACB_DMACFG’ undeclared (first use in this function);
 did you mean ‘MACB_MCF’?
  writel((value), (port)->regs + MACB_##reg)

It has been caused by changing macros name by commit below.

Fixes: 6c636514d499 ("net: macb: sync header definitions as taken from Linux")
Signed-off-by: Michal Simek <michal.simek at xilinx.com>

Xilinx is not using this driver. We are using zynq_gem one but I found it
when I was comparing one setting.

Tom: I would consider this as FIX and would be good if you can take it to
the current release but up2you.

 drivers/net/macb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 631b53b0930a..bd588cab06b3 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -807,7 +807,7 @@ static int _macb_init(struct macb_device *macb, const char *name)
 	macb->next_rx_tail = 0;
-	macb_writel(macb, DMACFG, MACB_ZYNQ_GEM_DMACR_INIT);
+	gem_writel(macb, DMACFG, MACB_ZYNQ_GEM_DMACR_INIT);
 	macb_writel(macb, RBQP, macb->rx_ring_dma);

More information about the U-Boot mailing list