[PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat

Rasmus Villemoes rasmus.villemoes at prevas.dk
Tue Mar 31 14:30:12 CEST 2020


On 23/03/2020 21.45, Tom Rini wrote:
> On Mon, Mar 23, 2020 at 01:13:01AM +0100, Rasmus Villemoes wrote:
>> On 03/03/2020 13.19, Rasmus Villemoes wrote:
>>> On 28/01/2020 13.04, Rasmus Villemoes wrote:
>>>> [resending with Mario's correct address, sorry for the double post]
>>>>
>>>> The driver correctly uses the shadow register when asked for the
>>>> current value of an output gpio. Unfortunately, it does RMW on the
>>>> gpdat register both when setting a gpio as input and output. These two
>>>> patches fix that.
>>>
>>> Ping. Any chance these fixes can make it to 2020.04 ?
>>
>> Ping^3.
>>
>> Tom, will you consider applying these directly? It's been two months and
>> I haven't got any response. Or advise on what I could do.
> 
> I suppose that if Mario doesn't speak up soon I'll take a look at
> picking them up myself, thanks!
> 

Thanks. And in the unlikely event you have plenty of time, can I also
have you look at the

https://patchwork.ozlabs.org/project/uboot/list/?series=157899

series? The mpc8xxx_spi driver is mostly unusable without the 4/5 patch,
at least for accessing flash devices - perhaps some other spi
peripherals never encounter the "transfer size is 3 mod 4".

Thanks,
Rasmus


More information about the U-Boot mailing list