[PATCH V2 14/14] ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board

[Marek Vasut]

On 3/31/20 4:59 PM, Patrick DELAUNAY wrote:
> Hi,

Hi,

>> It is also highly recommended to configure the board for the DHCOM make
>> stm32mp15_dhcom_basic_defconfig make DEVICE_TREE=stm32mp15xx-dhcor-
>> avenger96
>> as that permits reusing the board code for the DH components, like accessing and
>> reading out the ethernet MAC from EEPROM.
> 
> Recommended or mandatory...

Both work, the later provides more complete solution.

> For my point of view
> 
> - board/st/stm32mp1 manage the ST board (STM32MP15x-DKX and STM32MP15x-EV1)
>                                  Can be used as starting point for customer new board
> 
> - board/dhelectronics/dh_stm32mp1 manage the board based on DHCOR SoM or can be a starting point of SoM user
>  
> For AV96, the first upstream was directly based on ST board, but I agree : it is clearly not a perfect solution (MAC address issue for example)

Yes indeed.

> => support on this board should be in dh_stm32mp1 board or create a new board AV96 based on it.
> 
> And I need to continue to move in st/common the part common for all the STM32MP157 boards....

[...]

>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
>> 9c593b2c98..2564f790de 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -884,7 +884,8 @@ dtb-$(CONFIG_STM32MP15x) += \
>>  	stm32mp157c-dk2.dtb \
>>  	stm32mp157c-ed1.dtb \
>>  	stm32mp157c-ev1.dtb \
>> -	stm32mp15xx-dhcom-pdk2.dtb
>> +	stm32mp15xx-dhcom-pdk2.dtb \
>> +	stm32mp15xx-dhcor-avenger96.dtb
> 
> Force device tree support for each target ?
> Avoid to mix incompatible device tree and defconfig....
> 
> dtb-$(TARGET_ST_STM32MP15x) += \ 
> 	stm32mp157a-dk1.dtb \
>   	stm32mp157c-dk2.dtb \
>   	stm32mp157c-ed1.dtb \
>   	stm32mp157c-ev1.dtb
> 
> dtb-$(TARGET_DH_STM32MP1_PDK2) += \
> 	stm32mp15xx-dhcom-pdk2.dtb \
> 	stm32mp15xx-dhcor-avenger96.dtb

You probably want to build all DTs for STM32MP1 when building STM32MP1
platforms ?

[...]

(please, learn to trim the responses in email)

>> -&usbphyc {
>> -	status = "okay";
>> -};
>> -
>> -&usbphyc_port0 {
>> -	phy-supply = <&vdd_usb>;
>> -};
>> -
>> -&usbphyc_port1 {
>> -	phy-supply = <&vdd_usb>;
>> -};
> 
> When this file will be removed ? why kept this file.....
> I propose to completely remove this file (no device tree for same board)

Backward compatibility, I'd keep it in for a release or two.
But if removing it is fine, then so be it.

>> +/* This is kept for backward compatibility and will be removed */
>> +#include "stm32mp15xx-dhcor-avenger96.dts"
> 
> Missing u-boot file to avoid issue......
> 
> +#include " stm32mp15xx-dhcor-avenger96-u-boot.dtsi"

That's actually included via the avenger96.dts, so should be OK.
Although I am not real happy with that.

[...]

>>  Build Procedure
>>  ---------------
>> @@ -229,7 +229,7 @@ Build Procedure
>>
>>       # export KBUILD_OUTPUT=stm32mp15_basic
>>       # make stm32mp15_basic_defconfig
>> -     # make DEVICE_TREE=stm32mp157a-avenger96 all
>> +     # make DEVICE_TREE=stm32mp15xx-dhcor-avenger96 all
>>
>>  6. Output files
> 
> Reference could be removed if support if done by stm32mp15_dhcom_basic_defconfig / dh_stm32mp1 board

See my first question about the defconfig.