[PATCH v3 7/7] x86: Add a 64-bit coreboot build

[Bin Meng]

Hi Simon,

On Fri, May 1, 2020 at 12:21 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Am May 1, 2020 4:04:06 AM UTC schrieb Simon Glass <sjg at chromium.org>:
> >HI Heinrich,
> >
> >On Thu, 30 Apr 2020 at 21:57, Heinrich Schuchardt <xypron.glpk at gmx.de>
> >wrote:
> >>
> >> Am May 1, 2020 3:21:45 AM UTC schrieb Simon Glass <sjg at chromium.org>:
> >> >Add a build for running 64-bit U-Boot from coreboot (which is
> >32-bit).
> >> >This uses binman to create an image with a 32-bit SPL and a 64-bit
> >> >U-Boot.
> >> >
> >> >Coreboot boots into SPL and then SPL boots into U-Boot.
> >> >
> >> >This allows running 64-bit EFI images on x86.
> >> >Signed-off-by: Simon Glass <sjg at chromium.org>
> >> >---
> >> >
> >> >Changes in v3: None
> >> >Changes in v2: None
> >> >
> >> > board/coreboot/coreboot/MAINTAINERS |  7 +++++
> >> > configs/coreboot64_defconfig        | 48
> >+++++++++++++++++++++++++++++
> >> > doc/board/coreboot/coreboot.rst     | 10 ++++++
> >> > 3 files changed, 65 insertions(+)
> >> > create mode 100644 configs/coreboot64_defconfig
> >> >
> >> >diff --git a/board/coreboot/coreboot/MAINTAINERS
> >> >b/board/coreboot/coreboot/MAINTAINERS
> >> >index 188906b080..a05673bb0b 100644
> >> >--- a/board/coreboot/coreboot/MAINTAINERS
> >> >+++ b/board/coreboot/coreboot/MAINTAINERS
> >> >@@ -4,3 +4,10 @@ S:    Maintained
> >> > F:    board/coreboot/coreboot/
> >> > F:    include/configs/chromebook_link.h
> >> > F:    configs/coreboot_defconfig
> >> >+
> >> >+COREBOOT64 BOARD
> >> >+M:    Simon Glass <sjg at chromium.org>
> >> >+S:    Maintained
> >> >+F:    board/coreboot/coreboot/
> >> >+F:    include/configs/chromebook_link.h
> >> >+F:    configs/coreboot64_defconfig
> >> >diff --git a/configs/coreboot64_defconfig
> >> >b/configs/coreboot64_defconfig
> >> >new file mode 100644
> >> >index 0000000000..80353b8eb3
> >> >--- /dev/null
> >> >+++ b/configs/coreboot64_defconfig
> >> >@@ -0,0 +1,48 @@
> >> >+CONFIG_X86=y
> >> >+CONFIG_SYS_TEXT_BASE=0x1120000
> >> >+CONFIG_ENV_SIZE=0x1000
> >> >+CONFIG_NR_DRAM_BANKS=8
> >> >+CONFIG_PRE_CON_BUF_ADDR=0x100000
> >> >+CONFIG_X86_RUN_64BIT=y
> >> >+CONFIG_VENDOR_COREBOOT=y
> >> >+CONFIG_TARGET_COREBOOT=y
> >> >+CONFIG_SPL_TEXT_BASE=0x1110000
> >> >+CONFIG_FIT=y
> >> >+CONFIG_FIT_SIGNATURE=y
> >> >+CONFIG_SHOW_BOOT_PROGRESS=y
> >> >+CONFIG_USE_BOOTARGS=y
> >> >+CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro"
> >>
> >> Isn't this defconfig for a generic coreboot device? So why would you
> >prescribe a boot partition which may not exist? And what should a
> >non-Linux OS do with 'init='?
> >
> >What do you suggest?
> >
> >This matches the coreboot board and is the default boot device on one
> >board that uses this.
> >
>
> I thought this patch series is about boards booted via the fimware "Coreboot"  and not a specific board by chance also called "Coreboot". Please, clarify this in the commit message.
>
> And if this defconfig is for a specific board called "Coreboot" couldn't you add some indication of the vendor name to the defconfig filename to avoid further misunderstandings.
>
> Best regards
>

I left this patch unapplied since Heinrich has some comments. Please
rebase the next version on top of u-boot-x86/master.

Regards,
Bin