[PATCH 1/2] tools/mkimage: fix handling long filenames

Tom Rini trini at konsulko.com
Fri May 1 23:56:55 CEST 2020


On Mon, Apr 27, 2020 at 02:08:38AM +0200, Sven Roederer wrote:

> The cmdline for calling the dtc was cut-off when using long filenames (e.g.
> 245 bytes) for output-file and datafile of "-f" parameter.
> For FIT-images cmd[MKIMAGE_MAX_DTC_CMDLINE_LEN] is declared (hardcoded 512 bytes),
> and contains some static values, the path of a tmpfile and a datafile. tmpfile is
> max MKIMAGE_MAX_TMPFILE_LEN (256) and datafile might be also this size. Having two
> very long pathname results in a truncation os the executed shell command, as the
> truncated datafile path will not be found.
> Redefine MKIMAGE_MAX_DTC_CMDLINE_LEN to "2 * MKIMAGE_MAX_TMPFILE_LEN + 35 for the
> parameters.
> This likely applies to the "-d" parameter, too.
> 
> Signed-off-by: Sven Roederer <devel-sven at geroedel.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200501/556e85bd/attachment.sig>


More information about the U-Boot mailing list