[PATCH] clk: fix the console output of clk_register

Dario Binacchi dariobin at libero.it
Sat May 2 17:38:11 CEST 2020


The parent->name variable can be used only in case the
uclass_get_device_by_name routine returns successfully.

Signed-off-by: Dario Binacchi <dariobin at libero.it>
---

 drivers/clk/clk.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 4c477a488e..2ca8d63c5d 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -21,13 +21,13 @@ int clk_register(struct clk *clk, const char *drv_name,
 
 	ret = uclass_get_device_by_name(UCLASS_CLK, parent_name, &parent);
 	if (ret) {
-		printf("%s: name: %s parent: %s [0x%p]\n",
-		       __func__, name, parent->name, parent);
+		printf("%s: failed to get %s device (parent of %s)\n",
+		       __func__, parent_name, name);
+	} else {
+		debug("%s: name: %s parent: %s [0x%p]\n", __func__, name,
+		      parent->name, parent);
 	}
 
-	debug("%s: name: %s parent: %s [0x%p]\n", __func__, name, parent->name,
-	      parent);
-
 	drv = lists_driver_lookup_name(drv_name);
 	if (!drv) {
 		printf("%s: %s is not a valid driver name\n",
-- 
2.17.1



More information about the U-Boot mailing list