[PATCH v7 16/22] riscv: Enable cpu clock if it is present

Sean Anderson seanga2 at gmail.com
Sun May 3 19:17:17 CEST 2020

On 5/3/20 3:12 AM, Pragnesh Patel wrote:
> Hi Sean,
>> -----Original Message-----
>> From: Sean Anderson <seanga2 at gmail.com>
>> Sent: 02 May 2020 23:46
>> To: Pragnesh Patel <pragnesh.patel at sifive.com>; u-boot at lists.denx.de
>> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
>> bmeng.cn at gmail.com; Paul Walmsley <paul.walmsley at sifive.com>;
>> jagan at amarulasolutions.com; Troy Benjegerdes
>> <troy.benjegerdes at sifive.com>; anup.patel at wdc.com; Sagar Kadam
>> <sagar.kadam at sifive.com>; rick at andestech.com; Lukas Auer
>> <lukas.auer at aisec.fraunhofer.de>
>> Subject: Re: [PATCH v7 16/22] riscv: Enable cpu clock if it is present
>> [External Email] Do not click links or attachments unless you recognize the
>> sender and know the content is safe
>> On 5/2/20 6:06 AM, Pragnesh Patel wrote:
>>> The cpu clock is probably already enabled if we are executing code
>>> (though we could be executing from a different core). This patch
>>> prevents the cpu clock or its parents from being disabled.
>>> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
>> If you make substantial changes can you please make a note of it in the
>> commit? I did not sign off on *this* code.
> This patch is copied from your v9 series [1] and I made some changes, so the idea is to
> give credit to everyone who contributed.

That's fine, just please make a note when you make substantial changes.
For example, you could write

Signed-off-by: Sean Anderson <seanga2 at gmail.com>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
[set clock frequency from clock-frequency property]
Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>

so it's more clear what changes have been made since this patch was
posted last.


More information about the U-Boot mailing list