[PATCH] efi_loader: factor out the common code from efi_transfer_secure_state()

[Heinrich Schuchardt]

On 5/1/20 8:22 AM, Heinrich Schuchardt wrote:
> On 4/21/20 2:39 AM, AKASHI Takahiro wrote:
>> efi_set_secure_stat() provides the common code for each stat transition
>> caused by efi_transfer_secure_state().
>>
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
>> Suggested-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>>  lib/efi_loader/efi_variable.c | 194 +++++++++++-----------------------
>>  1 file changed, 64 insertions(+), 130 deletions(-)
>>
>> diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
>> index 0c6d1deb58eb..c275684278a1 100644
>> --- a/lib/efi_loader/efi_variable.c
>> +++ b/lib/efi_loader/efi_variable.c
>> @@ -176,6 +176,59 @@ static efi_status_t efi_set_variable_internal(u16 *variable_name,
>>  					      const void *data,
>>  					      bool ro_check);
>>
>> +/**
>> + * efi_set_secure_state - modify secure boot state variables
>> + * @sec_boot:		value of SecureBoot
>> + * @setup_mode:		value of SetupMode
>> + * @audit_mode:		value of AuditMode
>> + * @deployed_mode:	value of DeployedMode
>> + *
>> + * Modify secure boot stat-related variables as indicated.
>> + *
>> + * Return:	EFI_SUCCESS on success, status code (negative) on error
> According to the UEFI spec:
>
> EFI_STATUS Type UINTN
>
> So the return value cannot be negative. I will adjust the text when merging.
>
> Otherwise:
>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>

Patch is merged. Thanks Heinrich