[PATCH 22/36] bdinfo: Drop print_bi_flash()

Bin Meng bmeng.cn at gmail.com
Wed May 6 10:09:33 CEST 2020


Hi Simon,

On Tue, May 5, 2020 at 7:19 AM Simon Glass <sjg at chromium.org> wrote:
>
> This function only has three lines of code in it so inline it.

What's our guideline for inlining functions? To me if there is only
one line, inline the function looks good to me. But 3 lines? I am not
sure.

>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  cmd/bdinfo.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>

Regards,
Bin


More information about the U-Boot mailing list