[PATCH 20/36] bdinfo: sh: arc: Drop arch-specific print_bi_mem()

Alexey Brodkin Alexey.Brodkin at synopsys.com
Wed May 6 11:04:06 CEST 2020


Hi Simon,

> Subject: Re: [PATCH 20/36] bdinfo: sh: arc: Drop arch-specific print_bi_mem()
> 
> On Tue, May 5, 2020 at 7:19 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > It isn't worth having arch-specific code for such minor output
> > differences. In fact it is better if all archs are consistent.
> >
> > Drop the arch-specific code in print_bi_mem() and inline it to avoid a
> > two-line function.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  cmd/bdinfo.c | 17 ++---------------
> >  1 file changed, 2 insertions(+), 15 deletions(-)

I guess this entire series is available in the following tree, right?
https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/tree/bd-working

In that case I'm very happy with that change as well as removal
of the duplicated spaghetti-code - thanks for taking care of that!

Acked-by: Alexey Brodkin <abrodkin at synopsys.com>


More information about the U-Boot mailing list