[PATCH 22/36] bdinfo: Drop print_bi_flash()

[Simon Glass]

Hi Bin,

On Wed, 6 May 2020 at 02:09, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Tue, May 5, 2020 at 7:19 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > This function only has three lines of code in it so inline it.
>
> What's our guideline for inlining functions? To me if there is only
> one line, inline the function looks good to me. But 3 lines? I am not
> sure.

Me neither. But in this case I want to get all the code into once
place and the end result is a function with about 30 lines, which
seems OK.


>
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  cmd/bdinfo.c | 11 +++--------
> >  1 file changed, 3 insertions(+), 8 deletions(-)
> >
>

Regards,
SImon