[PATCH] cmd: gpt: add eMMC and GPT support

[Simon Glass]

Hi Heinrich,

On Tue, 5 May 2020 at 10:45, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 05.05.20 18:02, Simon Glass wrote:
> > Hi Rayagonda,
> >
> > On Tue, 5 May 2020 at 06:13, Rayagonda Kokatanur
> > <rayagonda.kokatanur at broadcom.com> wrote:
> >>
> >> From: Corneliu Doban <cdoban at broadcom.com>
> >>
> >> Add eMMC and GPT support.
> >> - GPT partition list and command to create the GPT added to u-boot
> >>   environment
> >> - eMMC boot commands added to u-boot environment
> >> - new gpt commands (enumarate and setenv) that are used by broadcom
> >>   update scripts and boot commands
> >> - eMMC specific u-boot configurations with environment saved in eMMC
> >>   and GPT support
> >>
> >> Signed-off-by: Corneliu Doban <cdoban at broadcom.com>
> >> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com>
> >>
> >> diff --git a/cmd/gpt.c b/cmd/gpt.c
> >> index b8d11c167d..c32e272b25 100644
> >> --- a/cmd/gpt.c
> >> +++ b/cmd/gpt.c
> >> @@ -616,6 +616,87 @@ static int gpt_verify(struct blk_desc *blk_dev_desc, const char *str_part)
> >>         return ret;
> >>  }
> >>
> >> +/*
> >> + * Enumerate partition names into environment variable.
> >> + */
> >
> > Can you check the style for these comments? You can see examples in
> > bootcount.h. Please fix for all functions.
>
>
> Unfortunately bootcount.h itself is in bad shape. Please, use
>
> https://www.kernel.org/doc/html/v4.10/doc-guide/kernel-doc.html#function-documentation
>
> as reference.

Thank you. I've added that to the wiki page.

https://www.denx.de/wiki/U-Boot/CodingStyle

Regards,
Simon
[..]