[PATCH v2 1/2] gpio: emulate open drain & open source in dm_gpio_set_value()

[Tom Rini]

On Wed, May 06, 2020 at 08:47:20AM -0600, Simon Glass wrote:
> Hi Neil,
> 
> +Tom Rini
> 
> On Tue, 5 May 2020 at 02:43, Neil Armstrong <narmstrong at baylibre.com> wrote:
> >
> > Handle the GPIOD_OPEN_DRAIN & GPIOD_OPEN_SOURCE flags to emulate open drain
> > and open source by setting the GPIO line as input depending on the
> > requested value.
> >
> > The behaviour is taken from the Linux gpiolib.
> >
> > Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>
> > ---
> >  drivers/gpio/gpio-uclass.c | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I wonder how we should handle small increases in functionality, like
> this. If a board doesn't want the code-stize hit in SPL, should we
> have it behind a Kconfig, like CONFIG_GPIO_EXTRA?

I suppose it'll come down to how much growth and where.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200506/36460744/attachment.sig>