[PATCH] Revert "mkimage: fit: Do not tail-pad fitImage with external data"

Marek Vasut marex at denx.de
Wed May 6 17:23:55 CEST 2020


On 5/6/20 5:19 PM, Tom Rini wrote:
> On Wed, May 06, 2020 at 05:08:12PM +0200, Marek Vasut wrote:
>> On 5/6/20 5:05 PM, Tom Rini wrote:
>>> This has been reported to break booting of U-Boot from SPL on a number
>>> of platforms due to a lack of alignment of the external data.  The
>>> issues this commit is addressing will need to be resolved another way.
>>>
>>> This reverts commit 20a154f95bfe0a3b5bfba90bea7f001c58217536.
>>>
>>> Reported-by: Alex Kiernan <alex.kiernan at gmail.com>
>>> Reported-by: Michael Walle <michael at walle.cc>
>>> Signed-off-by: Tom Rini <trini at konsulko.com>
>>
>> The commit message should also warn that this re-opens the data leak in
>> the padding.
> 
> Sure.  Are you going to send a patch switching to calloc or should I?

I think the discussion about the padding requirement isn't finished yet?
See my remark about the load = <>; part.


More information about the U-Boot mailing list