[PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi

Eugen.Hristev at microchip.com Eugen.Hristev at microchip.com
Thu May 7 12:19:14 CEST 2020


On 07.05.2020 12:21, Tiaki Rice wrote:

> Hello Eugen,
> 
> I'm new to this whole mailing list patchwork thingy so I suspect I didn't quite submit the patch correctly, maybe you can point me in the right direction.
> 
> What I did:
> - Made the changes on master and locally commited them
> - Created a patch using  'git format-patch' and modified the patch file email body.
> - Used 'git send-email' to send the patch to u-boot at lists.denx.de and Cc'd you
> 
> This opened my Outlook of which I checked to make sure the email was plain text and then sent it. Any ideas?
> 

Hi Tiaki,

 From my perspective you did everything very well. The patch looks sent 
fine. I would only have one question, did you check your patch with the 
built-in perl script that automatically checks your patch for formatting ?
./scripts/checkpatch.pl --strict <your patch file>

About patchwork, I think it may be an issue with patchwork.

Eugen


> 
> Thanks in advance,
> 
> Tiaki Rice
> 
> -----Original Message-----
> From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com>
> Sent: Thursday, 7 May 2020 7:12 PM
> To: tiakirice at hotmail.com; u-boot at lists.denx.de
> Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi
> 
> On 07.05.2020 07:43, Tiaki Rice wrote:
>> This patch adds support for uart4 to the processor level device tree include file.
>>
>>
>> Signed-off-by: Tiaki Rice <tiakirice at hotmail.com>
>> Cc: Eugen Hristev <Eugen.Hristev at microchip.com>
>> ---
> 
> Hi,
> 
> Thanks for contributing !
> 
> I have an issue with this patch missing from patchwork.
> Anyone has any idea why that happened ?
> 
> Eugen
> 
>>    arch/arm/dts/sama5d2.dtsi | 8 ++++++++
>>    1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
>> index 5adc47b906..6fb2cb25f9 100644
>> --- a/arch/arm/dts/sama5d2.dtsi
>> +++ b/arch/arm/dts/sama5d2.dtsi
>> @@ -746,6 +746,14 @@
>>    status = "disabled";
>>    };
>>
>> +uart4: serial at fc00c000 {
>> +compatible = "atmel,at91sam9260-usart"; reg = <0xfc00c000 0x100>;
>> +clocks = <&uart4_clk>; clock-names = "usart"; status = "disabled"; };
>> +
>>    i2c1: i2c at fc028000 {
>>    compatible = "atmel,sama5d2-i2c";
>>    reg = <0xfc028000 0x100>;
>> --
>> 2.22.0.windows.1
>>
> 



More information about the U-Boot mailing list