[PATCH] ARM: uniphier: delete or replace <common.h> includes

[Simon Glass]

Hi Masahiro,

On Thu, 7 May 2020 at 07:10, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
>
> <common.h> pulls in a lot of bloat. <common.h> is unneeded in most of
> places.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>
>  arch/arm/mach-uniphier/arm32/cache-uniphier.c         | 1 -
>  arch/arm/mach-uniphier/arm32/psci.c                   | 1 -
>  arch/arm/mach-uniphier/arm32/timer.c                  | 2 +-
>  arch/arm/mach-uniphier/arm64/mem_map.c                | 1 -
>  arch/arm/mach-uniphier/base-address.c                 | 2 +-
>  arch/arm/mach-uniphier/board_late_init.c              | 1 -
>  arch/arm/mach-uniphier/boards.c                       | 2 +-
>  arch/arm/mach-uniphier/boot-device/boot-device-ld11.c | 1 -
>  arch/arm/mach-uniphier/boot-device/boot-device-ld4.c  | 1 -
>  arch/arm/mach-uniphier/boot-device/boot-device-pro5.c | 1 -
>  arch/arm/mach-uniphier/boot-device/boot-device-pxs2.c | 1 -
>  arch/arm/mach-uniphier/boot-device/boot-device-pxs3.c | 2 +-
>  arch/arm/mach-uniphier/boot-device/boot-device.c      | 4 +++-
>  arch/arm/mach-uniphier/clk/clk-dram-ld4.c             | 1 -
>  arch/arm/mach-uniphier/clk/clk-dram-pxs2.c            | 1 -
>  arch/arm/mach-uniphier/clk/clk-early-ld4.c            | 1 -
>  arch/arm/mach-uniphier/clk/clk-ld11.c                 | 2 +-
>  arch/arm/mach-uniphier/clk/dpll-ld4.c                 | 2 +-
>  arch/arm/mach-uniphier/clk/dpll-pro4.c                | 2 +-
>  arch/arm/mach-uniphier/debug-uart/debug-uart.c        | 1 -
>  arch/arm/mach-uniphier/dram/cmd_ddrmphy.c             | 3 +--
>  arch/arm/mach-uniphier/dram/cmd_ddrphy.c              | 2 +-
>  arch/arm/mach-uniphier/dram/umc-ld4.c                 | 1 -
>  arch/arm/mach-uniphier/dram/umc-pro4.c                | 1 -
>  arch/arm/mach-uniphier/dram/umc-sld8.c                | 1 -
>  arch/arm/mach-uniphier/dram_init.c                    | 2 +-
>  arch/arm/mach-uniphier/fdt-fixup.c                    | 2 +-
>  arch/arm/mach-uniphier/init.h                         | 1 +
>  arch/arm/mach-uniphier/memconf.c                      | 1 -
>  arch/arm/mach-uniphier/micro-support-card.c           | 3 ++-
>  arch/arm/mach-uniphier/mmc-boot-mode.c                | 1 -
>  arch/arm/mach-uniphier/mmc-first-dev.c                | 2 +-
>  arch/arm/mach-uniphier/pinctrl-glue.c                 | 1 -
>  arch/arm/mach-uniphier/reset.c                        | 1 -
>  arch/arm/mach-uniphier/sbc/sbc-ld11.c                 | 1 -
>  arch/arm/mach-uniphier/sbc/sbc.c                      | 1 -
>  arch/arm/mach-uniphier/spl_board_init.c               | 1 -
>  37 files changed, 18 insertions(+), 37 deletions(-)
>

I'm wary of this. I think that every file should include common.h and
the solution is to remove the bloat. I have been plugging away at
that. There is a pending series that reduces it down further, to 14
includes. Please help review!

http://patchwork.ozlabs.org/project/uboot/list/?series=169491

The problem is that when someone uses #ifdef CONFIG options the
config.h has to be included. So your patch is a bit brittle. As soon
as someone uses CONFIG it may break.

Anyway this is uniphier code so it's up to you.

Regards,
Simon