[PATCH 2/4] sata: ahsata: Fix wrong operand for checking SERR DIAG_X

Tom Rini trini at konsulko.com
Sat May 9 00:59:22 CEST 2020


On Sun, May 03, 2020 at 10:27:01PM +0800, Peng Fan wrote:

> From: Ye Li <ye.li at nxp.com>
> 
> Fix coverity issue CID 3261683: Wrong operator used
> (CONSTANT_EXPRESSION_RESULT) operator_confusion:
> ({...; __v;}) | 67108864 is always 1/true regardless of the values
> of its operand. This occurs as the logical operand of !
> 
> When DIAG_X is set, the PHY COMINIT signal is detected, so
> should use '&' to check whether it is set.
> 
> Signed-off-by: Ye Li <ye.li at nxp.com>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200508/631fdc45/attachment.sig>


More information about the U-Boot mailing list