[PATCH 1/1] tools: ftdgrep: use /* fallthrough */ as needed

[Masahiro Yamada]

On Sun, May 10, 2020 at 12:12 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> GCC recognizes /* fallthrough */ if -Wimplicit-fallthrough=3 is enabled.

FYI.

Linux decided to not use /* fallthrough */ any more
because Clang does not recognize it.

__attribute__((__fallthrough__)) is supported
by both Clang and recent GCC.


Linux is now doing treewide conversion
from /* fallthrough */ to 'fallthrough;'.

See include/linux/compiler_attributes.h in Linux.

I do not know if U-Boot wants to align with it.
(up to Tom ?)






> Let's use it consistently.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  tools/fdtgrep.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c
> index 7e168a1e6b..8b4d2765ad 100644
> --- a/tools/fdtgrep.c
> +++ b/tools/fdtgrep.c
> @@ -923,7 +923,9 @@ static const char usage_synopsis[] =
>  /* Helper for getopt case statements */
>  #define case_USAGE_COMMON_FLAGS \
>         case 'h': usage(NULL); \
> +       /* fallthrough */ \
>         case 'V': util_version(); \
> +       /* fallthrough */ \
>         case '?': usage("unknown option");
>
>  static const char usage_short_opts[] =
> @@ -1085,6 +1087,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
>
>                 switch (opt) {
>                 case_USAGE_COMMON_FLAGS
> +               /* fallthrough */
>                 case 'a':
>                         disp->show_addr = 1;
>                         break;
> @@ -1096,7 +1099,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
>                         break;
>                 case 'C':
>                         inc = 0;
> -                       /* no break */
> +                       /* fallthrough */
>                 case 'c':
>                         type = FDT_IS_COMPAT;
>                         break;
> @@ -1111,7 +1114,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
>                         break;
>                 case 'G':
>                         inc = 0;
> -                       /* no break */
> +                       /* fallthrough */
>                 case 'g':
>                         type = FDT_ANY_GLOBAL;
>                         break;
> @@ -1129,7 +1132,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
>                         break;
>                 case 'N':
>                         inc = 0;
> -                       /* no break */
> +                       /* fallthrough */
>                 case 'n':
>                         type = FDT_IS_NODE;
>                         break;
> @@ -1148,7 +1151,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
>                         break;
>                 case 'P':
>                         inc = 0;
> -                       /* no break */
> +                       /* fallthrough */
>                 case 'p':
>                         type = FDT_IS_PROP;
>                         break;
> --
> 2.26.2
>


-- 
Best Regards
Masahiro Yamada