[PATCH v2 2/2] arch: x86: apl: Use devicetree for FSP configuration

Simon Glass sjg at chromium.org
Sun May 10 22:44:16 CEST 2020


On Thu, 7 May 2020 at 02:00, Bernhard Messerklinger
<bernhard.messerklinger at br-automation.com> wrote:
>
> A the moment the FSP configuration is a mix of hard coded values and
> devicetree properties.
> This patch makes FSP-M and FSP-S full configurable from devicetree by
> adding binding properties for all FSP parameters.
> Co-developed-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> Signed-off-by: Bernhard Messerklinger <bernhard.messerklinger at br-automation.com>
>
> ---
>
> Changes in v2:
> Integration of the review comments
> Fix swizzle size bug
>
>  arch/x86/cpu/apollolake/Makefile              |    1 +
>  arch/x86/cpu/apollolake/fsp_bindings.c        | 1803 +++++++++++++++++
>  arch/x86/cpu/apollolake/fsp_m.c               |  169 +-
>  arch/x86/cpu/apollolake/fsp_s.c               |  386 +---
>  arch/x86/dts/chromebook_coral.dts             |   72 +-
>  .../asm/arch-apollolake/fsp/fsp_m_upd.h       |  168 ++
>  .../asm/arch-apollolake/fsp/fsp_s_upd.h       |  202 ++
>  .../asm/arch-apollolake/fsp_bindings.h        |  110 +
>  .../fsp/fsp2/apollolake/fsp-m.txt             |  320 +++
>  .../fsp/fsp2/apollolake/fsp-s.txt             |  483 +++++
>  10 files changed, 3163 insertions(+), 551 deletions(-)
>  create mode 100644 arch/x86/cpu/apollolake/fsp_bindings.c
>  create mode 100644 arch/x86/include/asm/arch-apollolake/fsp_bindings.h
>  create mode 100644 doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-m.txt
>  create mode 100644 doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-s.txt
>

Reviewed-by: Simon Glass <sjg at chromium.org>
Tested on chromebook_coral:
Tested-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list