[PATCH v3 11/22] common: Drop init.h from common header
masahiroy at kernel.org
Mon May 11 09:04:16 CEST 2020
On Mon, May 11, 2020 at 3:44 PM Masahiro Yamada <masahiroy at kernel.org> wrote:
> On Mon, May 11, 2020 at 7:58 AM Simon Glass <sjg at chromium.org> wrote:
> > Move this uncommon header out of the common header.
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> Why are you adding <init.h> to
> which does not include <common.h>
> in the first place?
> This seems a wrong conversion.
> For uniphier, NACK.
Hmm, are you fixing -Wmissing-prototypes,
which is displayed with W=1 builds.
If so, adding <init.h> to arch/arm/mach-uniphier/cpu-info.c
makes sense although it is unclear from commit log.
But, I still do not understand why you are adding <init.h> to
It looks fine to me as-is.
More information about the U-Boot