[PATCH v3 21/22] Use __ASSEMBLY__ as the assembly macros

Simon Glass sjg at chromium.org
Mon May 11 22:28:54 CEST 2020


Hi Masahiro,

On Sun, 10 May 2020 at 22:57, Masahiro Yamada <masahiroy at kernel.org> wrote:
>
> On Mon, May 11, 2020 at 2:43 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > Some places use __ASSEMBLER__ instead which does not work since the
> > Makefile does not define it. Fix them.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
>
>
> I think we decided to not do this in v2, didn't we?
>
> http://patchwork.ozlabs.org/project/uboot/patch/20200409201506.133129-6-sjg@chromium.org/

I must have misunderstood that thread. I think we should be consistent
in U-Boot as to which one we use. It makes it much harder to check
things when there are multiple options.

Regards,
Simon



>
>
> > ---
> >
> > Changes in v3: None
> > Changes in v2:
> > - Add new patch to fix occurances of __ASSEMBLER__
> >
> >  arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h     | 2 +-
> >  arch/arm/include/asm/arch-mx27/regs-rtc.h                  | 2 +-
> >  arch/arm/include/asm/arch-mx5/imx-regs.h                   | 2 +-
> >  arch/arm/include/asm/arch-mx6/imx-regs.h                   | 2 +-
> >  arch/arm/include/asm/arch-mx7/imx-regs.h                   | 2 +-
> >  arch/arm/include/asm/arch-s32v234/imx-regs.h               | 2 +-
> >  arch/arm/include/asm/arch-vf610/imx-regs.h                 | 2 +-
> >  arch/arm/mach-socfpga/include/mach/clock_manager.h         | 2 +-
> >  arch/arm/mach-socfpga/include/mach/clock_manager_arria10.h | 4 ++--
> >  arch/arm/mach-socfpga/include/mach/clock_manager_gen5.h    | 4 ++--
> >  arch/arm/mach-socfpga/include/mach/sdram_arria10.h         | 2 +-
> >  arch/arm/mach-stm32mp/include/mach/stm32.h                 | 2 +-
> >  arch/x86/include/asm/mtrr.h                                | 2 +-
> >  arch/x86/include/asm/sipi.h                                | 4 ++--
> >  include/atf_common.h                                       | 2 +-
> >  include/elf.h                                              | 4 ++--
> >  16 files changed, 20 insertions(+), 20 deletions(-)
> >


More information about the U-Boot mailing list