[PATCH 3/8] imx8mp: ddr: Add inline ECC feature support

[Peng Fan]

> Subject: Re: [PATCH 3/8] imx8mp: ddr: Add inline ECC feature support
> 
> Hi Peng,
> 
> On Mon, May 11, 2020 at 6:30 AM Peng Fan <peng.fan at nxp.com> wrote:
> >
> > From: Sherry Sun <sherry.sun at nxp.com>
> >
> > Add inline ECC support for lpddr4 on imx8mp-evk. And add a config
> > which can enable/disable inline ECC feature for lpddr4 on imx8mp-evk
> board.
> 
> Please elaborate more on this inline ECC feature: when and why does it need
> to be selected, for example.

ok.

> 
> > --- a/board/freescale/imx8mp_evk/lpddr4_timing.c
> > +++ b/board/freescale/imx8mp_evk/lpddr4_timing.c
> > @@ -14,6 +14,9 @@ struct dram_cfg_param ddr_ddrc_cfg[] = {
> >         { 0x3d400020, 0x323 },
> >         { 0x3d400024, 0x1e84800 },
> >         { 0x3d400064, 0x7a0118 },
> > +#ifdef CONFIG_IMX8M_DRAM_INLINE_ECC
> 
> I see no user for this symbol at the moment.
> 
> It is usually better to introduce the symbol when there is a real user for it.

This is the the just the driver part. To enable this feature, we need a dedicated
defconfig. The defconfig part will be posted in other patches.

Thanks,
Peng.