[PATCH 1/1] tools: mkimage: use /* fallthrough */ as needed
Punit Agrawal
punit1.agrawal at toshiba.co.jp
Tue May 12 04:12:07 CEST 2020
Heinrich Schuchardt <xypron.glpk at gmx.de> writes:
> GCC recognizes /* fallthrough */ if -Wimplicit-fallthrough=3 is enabled.
> Let's use it consistently.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
> tools/mkimage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/mkimage.c b/tools/mkimage.c
> index 336376f8d0..5689e5d75f 100644
> --- a/tools/mkimage.c
> +++ b/tools/mkimage.c
> @@ -211,7 +211,7 @@ static void process_args(int argc, char **argv)
> case 'f':
> datafile = optarg;
> params.auto_its = !strcmp(datafile, "auto");
> - /* no break */
> + /* fallthrough */
> case 'F':
> /*
> * The flattened image tree (FIT) format
> --
> 2.26.2
Looks good. Fwiw,
Reviewed-by: Punit Agrawal <punit1.agrawal at toshiba.co.jp>
Thanks.
More information about the U-Boot
mailing list