[PATCH v4 12/16] usb: dwc3: add make compatible for rockchip platform

Frank Wang frank.wang at rock-chips.com
Wed May 13 02:47:32 CEST 2020


Hi Marek,

On 2020/5/12 15:26, Marek Vasut wrote:
> On 5/12/20 3:08 AM, Frank Wang wrote:
>> Hi Marek,
>>
>> On 2020/5/11 17:48, Marek Vasut wrote:
>>> On 5/11/20 9:57 AM, Frank Wang wrote:
>>> [...]
>>>
>>>> @@ -394,6 +407,12 @@ static int dwc3_glue_probe(struct udevice *dev)
>>>>        if (ret)
>>>>            return ret;
>>>>    +    if (glue->resets.count < 1) {
>>> This condition is only true if count == 0 ?
>>> What's the purpose of this test ?
>> For previous dts of the Linux kernel, the reset phandles were in
>> dwc3-glue nodes, however, they are moved recently into dwc3 that is a
>> child node of dwc3-glue.
>>
>> So the above codes is to make compatible.
> Why doesn't it check for count == 0 then ?
>
Will fix.


BR,
Frank





More information about the U-Boot mailing list