[PATCH 5/5] mtd: spi: Use IS_ENABLED to prevent ifdef

Rasmus Villemoes rasmus.villemoes at prevas.dk
Fri May 15 09:33:58 CEST 2020


On 15/05/2020 09.22, Rasmus Villemoes wrote:

> That should make it obvious why one needs a variant that doesn't want
> the CONFIG_ included in the argument; the CONFIG_IS_ENABLED macro needs
> to do token-pasting with either CONFIG_SPL_ or just CONFIG_.

On that note, I think all hits from

  git grep 'CONFIG_IS_ENABLED(CONFIG_'

are bugs.

Another "script" that might be worth doing is finding instances of
CONFIG_IS_ENABLED(FOO) where SPL_FOO doesn't exist as a Kconfig symbol
(or perhaps in the whitelist), and conversely finding IS_ENABLED(FOO)
when there actually is a separate SPL_FOO symbol.

Rasmus


More information about the U-Boot mailing list