[PATCH v9 04/18] lib: Makefile: build crc7.c when CONFIG_MMC_SPI

Bin Meng bmeng.cn at gmail.com
Sun May 17 14:02:30 CEST 2020


On Wed, May 13, 2020 at 2:27 PM Pragnesh Patel
<pragnesh.patel at sifive.com> wrote:
>
> When build U-Boot SPL, meet an issue of undefined reference to
> 'crc7' for drivers/mmc/mmc_spi.c, so let's compile crc7.c when
> CONFIG_MMC_SPI selected.
>
> Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
> ---
>  lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index c6f862b0c2..a6812ea4a3 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -30,7 +30,6 @@ obj-y += charset.o
>  endif
>  endif
>  obj-$(CONFIG_USB_TTY) += circbuf.o
> -obj-y += crc7.o

Why not change this line?

>  obj-y += crc8.o
>  obj-y += crc16.o
>  obj-$(CONFIG_ERRNO_STR) += errno_str.o
> @@ -90,6 +89,7 @@ obj-y += errno.o
>  obj-y += display_options.o
>  CFLAGS_display_options.o := $(if $(BUILD_TAG),-DBUILD_TAG='"$(BUILD_TAG)"')
>  obj-$(CONFIG_BCH) += bch.o
> +obj-$(CONFIG_MMC_SPI) += crc7.o

but inserting the changes here?

>  obj-y += crc32.o
>  obj-$(CONFIG_CRC32C) += crc32c.o
>  obj-y += ctype.o
> --

Regards,
Bin


More information about the U-Boot mailing list