[PATCH v3 3/3] arch: x86: apl: Use devicetree for FSP-S configuration

[Bin Meng]

Hi Simon,

On Tue, May 12, 2020 at 3:35 PM Bernhard Messerklinger
<bernhard.messerklinger at br-automation.com> wrote:
>
> A the moment the FSP-S configuration is a mix of hard coded values and
> devicetree properties.
> This patch makes FSP-S full configurable from devicetree by
> adding binding properties for all FSP-S parameters.
> Co-developed-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> Signed-off-by: Bernhard Messerklinger <bernhard.messerklinger at br-automation.com>
>
> ---
>
> Changes in v3:
> Split patch into FSP-M and FSP-S
> Fix #if defined macro for FSP-S path to reduce SPL size
>
> Changes in v2:
> Integration of the review comments
> Fix swizzle size bug
>
>  arch/x86/cpu/apollolake/fsp_bindings.c        | 1189 +++++++++++++++++
>  arch/x86/cpu/apollolake/fsp_s.c               |  386 +-----
>  arch/x86/dts/chromebook_coral.dts             |   35 +-
>  .../asm/arch-apollolake/fsp/fsp_s_upd.h       |  202 +++
>  .../asm/arch-apollolake/fsp_bindings.h        |   14 +
>  .../fsp/fsp2/apollolake/fsp-s.txt             |  483 +++++++
>  6 files changed, 1922 insertions(+), 387 deletions(-)
>  create mode 100644 doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-s.txt
>

Could you please give a "Reviewed-by" or "Tested-by"?

Regards,
Bin