[PATCH v9 04/18] lib: Makefile: build crc7.c when CONFIG_MMC_SPI

[Bin Meng]

On Sun, May 17, 2020 at 10:28 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Am May 17, 2020 12:02:30 PM UTC schrieb Bin Meng <bmeng.cn at gmail.com>:
> >On Wed, May 13, 2020 at 2:27 PM Pragnesh Patel
> ><pragnesh.patel at sifive.com> wrote:
> >>
> >> When build U-Boot SPL, meet an issue of undefined reference to
> >> 'crc7' for drivers/mmc/mmc_spi.c, so let's compile crc7.c when
> >> CONFIG_MMC_SPI selected.
> >>
> >> Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
> >> ---
> >>  lib/Makefile | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/lib/Makefile b/lib/Makefile
> >> index c6f862b0c2..a6812ea4a3 100644
> >> --- a/lib/Makefile
> >> +++ b/lib/Makefile
> >> @@ -30,7 +30,6 @@ obj-y += charset.o
> >>  endif
> >>  endif
> >>  obj-$(CONFIG_USB_TTY) += circbuf.o
> >> -obj-y += crc7.o
> >
> >Why not change this line?
>
> This line is inside an if statement and ignored when building SPL.
>
> The patch fixes two issues:
>
> * building crc7 when not needed in main U-Boot
> * not building crc7 when required in SPL

Thanks for the clarifications!

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>