[PATCH] checkpatch.pl: Add check for defining CONFIG_CMD_xxx via config files

Tom Rini trini at konsulko.com
Thu May 21 22:32:20 CEST 2020


All of our cmds have a Kconfig entry.  Making enabling a CMD via the
config file an error to checkpatch.pl.

Signed-off-by: Tom Rini <trini at konsulko.com>
---
 scripts/checkpatch.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c2641bc995e8..5c0317c67fdb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6502,6 +6502,12 @@ sub process {
 			      "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr);
 		}
 
+# Defining new CONFIG_CMD is wrong.
+		if ($line =~ /\+\s*#\s*define\s+(CONFIG_CMD\w*)\b/) {
+			ERROR("DEFINE_CONFIG_CMD",
+			      "#define of '$1' is wrong - use Kconfig entries instead\n" . $herecurr);
+		}
+
 # likely/unlikely comparisons similar to "(likely(foo) > 0)"
 		if ($perl_version_ok &&
 		    $line =~ /\b((?:un)?likely)\s*\(\s*$FuncArg\s*\)\s*$Compare/) {
-- 
2.17.1



More information about the U-Boot mailing list