[PATCH 05/26] video: Split out expression parts into variables

Anatolij Gustschin agust at denx.de
Fri May 22 16:02:33 CEST 2020

On Tue, 19 May 2020 17:10:37 -0600
Simon Glass sjg at chromium.org wrote:

> The functions in this file do similar things but not always in the same
> way. To make the code easier to read and compare, use a separate 'linenum'
> variable in every function. This is then multiplied by the line length to
> get the offset within the frame buffer to modify. Also use an 'x' variable
> to hold the pixel position within that line. This is multipled by the
> pixel size and added to the offset.
> Also move the pbytes declaration up a little with the other long lines.
> A side effect of splitting out these variables is that they are promoted
> to int, i.e. a signed type, from the unsigned short used in the
> vidconsole_priv struct. This would be necessary should any of the
> variables go negative. At present this can actually happen in
> console_putc_xy_2(), if the display width is not a multiple of the
> character size (see next patch).
> Signed-off-by: Simon Glass <sjg at chromium.org>

Reviewed-by: Anatolij Gustschin <agust at denx.de>

More information about the U-Boot mailing list