[PATCH v3 11/13] cbfs: Change file_cbfs_find_uncached() to return an error
Bin Meng
bmeng.cn at gmail.com
Sat May 23 15:27:10 CEST 2020
On Sat, May 23, 2020 at 12:32 AM Simon Glass <sjg at chromium.org> wrote:
>
> This function currently returns a node pointer so there is no way to know
> the error code. Also it uses data in BSS which seems unnecessary since the
> caller might prefer to use a local variable.
>
> Update the function and split its body out into a separate function so we
> can use it later.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Fix s/u8/void/ in find_uncached()
> - Fix setting of start in file_cbfs_find_uncached()
> - Add more comments on @node in file_cbfs_find_uncached()
>
> fs/cbfs/cbfs.c | 48 +++++++++++++++++++++++++++---------------------
> include/cbfs.h | 17 +++++++++--------
> 2 files changed, 36 insertions(+), 29 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
More information about the U-Boot
mailing list