[PATCH v4] net: tftp: Add client support for RFC 7440

Ramon Fried rfried.dev at gmail.com
Sat May 23 19:59:53 CEST 2020


On Sat, May 23, 2020 at 8:40 PM Matthias Brugger <matthias.bgg at gmail.com> wrote:
...
>
> I think it makes more sense to check:
> if (tftp_window_size_option > 1 && tftp_state == STATE_SEND_RRQ)
>
> Because I understand that the tftp_state will change while the
> tftp_window_size_option is set or at compile time or through the environment. So
> we can save the check of the tftp_state if we have the default value.
>
> Regards,
> Matthias
>
The tftp_state can be only STATE_SEND_RRQ or STATE_SEND_WRQ and it's checked
one time per transfer, it won't change in the middle of transfer.
This code is run one time per transfer.
Thanks,
Ramon


More information about the U-Boot mailing list