[PATCH] mmc: davinci_mmc: Cleanup to use dt in U-boot and static platdata in SPL

[Faiz Abbas]

Hi Simon,

On 25/05/20 8:27 pm, Simon Glass wrote:
> Hi Faiz,
> 
> On Thu, 21 May 2020 at 20:02, Faiz Abbas <faiz_abbas at ti.com> wrote:
>>
>> Cleanup this driver to use dt in U-boot and static platdata in SPL.
>> This requires the following steps:
>>
>> 1. Move all platdata assignment from probe() to ofdata_to_platdata().
>>    This function is only called in U-boot.
>> 2. Replicate all the platdata assignment being done in
>>    ofdata_to_platdata() in the omapl138 board file. This data is used in
>>    the SPL case where SPL_OF_CONTROL is not enabled.
>> 3. Remove SPL_OF_CONTROL and related configs from omapl138_lcdk_defconfig
>>
>> This cleanup effectively reverts 3ef94715cc ('mmc: davinci: fix mmc boot in SPL')
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas at ti.com>
>> ---
>>
>> This patch fixes things being broken by Simon's series disabling
>> libfdt when using of-platdata:
>> https://patchwork.ozlabs.org/project/uboot/cover/20191107155318.103300-1-sjg@chromium.org/
>>
>>
>>  .../mach-davinci/include/mach/sdmmc_defs.h    |  7 +++
>>  board/davinci/da8xxevm/omapl138_lcdk.c        | 12 ++++
>>  configs/omapl138_lcdk_defconfig               |  4 --
>>  drivers/mmc/davinci_mmc.c                     | 63 ++++++++-----------
>>  4 files changed, 45 insertions(+), 41 deletions(-)
> 
> Could this use of-platdata instead?
> 

We would need to implement address translation in of-platdata to do that. I prefer merging your
fixes with this for now and leave of-platdata up for the future.

Thanks,
Faiz