[PATCH 4/4] x86: apl: Add hex offsets for registers in FSP-S

[Bin Meng]

Hi Simon,

On Tue, May 26, 2020 at 4:16 AM Simon Glass <sjg at chromium.org> wrote:
>
> When comparing hex dumps it is useful to see the offsets of the registers.
> Add them in where they correspond to a multiple of 16.
>
> Possibly it would be useful to have a a command to output the FSP values
> in human-readable form, making use of the fsp_bindings implementation.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  .../asm/arch-apollolake/fsp/fsp_s_upd.h       | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)
>
> diff --git a/arch/x86/include/asm/arch-apollolake/fsp/fsp_s_upd.h b/arch/x86/include/asm/arch-apollolake/fsp/fsp_s_upd.h
> index 87596ffd9d..f9c3985c47 100644
> --- a/arch/x86/include/asm/arch-apollolake/fsp/fsp_s_upd.h
> +++ b/arch/x86/include/asm/arch-apollolake/fsp/fsp_s_upd.h
> @@ -9,7 +9,14 @@
>  #ifndef __ASSEMBLY__
>  #include <asm/fsp2/fsp_api.h>
>
> +/* struct fsp_s_config - FSP-S configuration

nits: incorrect multi-line comment format

> + *
> + * Note that struct fsp_upd_header preceeds this and is 32 bytes long. The
> + * hex offsets mentioned in this file are relative to the start of the header,
> + * the same convention used in Intel's APL FSP header file.
> + */
>  struct __packed fsp_s_config {
> +       /* 20 */

Please add 0x prefix to these numbers ...

>         u8      active_processor_cores;
>         u8      disable_core1;
>         u8      disable_core2;
> @@ -26,6 +33,8 @@ struct __packed fsp_s_config {
>         u8      c_state_auto_demotion;
>         u8      c_state_un_demotion;
>         u8      max_core_c_state;
> +

[snip]

Regards,
Bin