[PATCH] video: ipuv3: remove some useless code to reduce binary size

Tom Rini trini at konsulko.com
Tue May 26 23:11:21 CEST 2020

On Tue, May 26, 2020 at 11:03:15PM +0200, Anatolij Gustschin wrote:
> On Mon, 25 May 2020 12:05:14 -0400
> Tom Rini trini at konsulko.com wrote:
> > On Mon, May 25, 2020 at 02:34:17PM +0200, Anatolij Gustschin wrote:
> > 
> > > To enable DM_VIDEO we must decrease binary size to fix build
> > > breakage for some boards, so drop not needed code. Also add
> > > !DM_VIDEO guards which can be later removed when last non DM
> > > users will be converted.
> > > 
> > > Signed-off-by: Anatolij Gustschin <agust at denx.de>  
> > 
> > Given that the migration deadline for non-DM video boards was the
> > v2019.07 release, what's the case for not:
> > 1. Perform the changes here, to save size.
> I've submitted more patches to save size, changes here were
> not enough to fix building tbs2910 board with DM video enabled.

Thanks a lot for doing all of this.

> > 2. Enable conversions that can now be enabled.
> All boards using ipuv3 driver are now converted, I'll submit a
> pull request to merge the changes.

OK, I'll take it for -next so you can wait a bit more or I'll queue it
up for when I open -next.

> > 3. Disable video/drop platforms on unconverted boards.
> For boards with only DM video conversion missing, it makes sense
> to disable video, but I don't know is this can be done for all
> such boards (some do not have serial console and rely on working
> display output). Some boards do not even enable DM, these are
> candidates to drop.

It's a tough call.  I think just disabling video support, and CC'ing the
maintainer is fine.  That should cause one of:
- Maintainer says they'll get to converting, does so.
- Maintainer says they don't want to maintain the platform anymore (see
  mx23evk for example).
- Maintainer email bounces.

In the latter case we can (or rather, let me know, I will..) do a
removal patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200526/26d31bef/attachment.sig>

More information about the U-Boot mailing list