[PATCH v3 4/4] spl: fit: improve spl_nand_fit_read(...) readability
Dario Binacchi
dariobin at libero.it
Wed May 27 13:56:21 CEST 2020
Replacing the ret variable with err and handling first the error
condition about the value returned by the spl_nand_fit_read routine,
improves the code readability.
Furthermore, the 'else' int the 'else return ret' instruction was
useless.
cc: Michael Trimarchi <michael at amarulasolutions.com>
Signed-off-by: Dario Binacchi <dariobin at libero.it>
---
Changes in v3: None
Changes in v2: None
common/spl/spl_nand.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/common/spl/spl_nand.c b/common/spl/spl_nand.c
index 1e6f2dce56..d13a524597 100644
--- a/common/spl/spl_nand.c
+++ b/common/spl/spl_nand.c
@@ -43,15 +43,15 @@ static ulong spl_nand_fit_read(struct spl_load_info *load, ulong offs,
ulong size, void *dst)
{
ulong sector;
- int ret;
+ int err;
sector = *(int *)load->priv;
offs = sector + nand_spl_adjust_offset(sector, offs - sector);
- ret = nand_spl_load_image(offs, size, dst);
- if (!ret)
- return size;
- else
+ err = nand_spl_load_image(offs, size, dst);
+ if (err)
return 0;
+
+ return size;
}
static int spl_nand_load_element(struct spl_image_info *spl_image,
--
2.17.1
More information about the U-Boot
mailing list