[PATCH][v4 5/6] board: tbs2910: Enable distro_boot support.

[Soeren Moch]

On 27.05.20 02:39, Denis 'GNUtoo' Carikli wrote:
> On Sun, 1 Mar 2020 14:59:04 +0100
> Soeren Moch <smoch at web.de> wrote:
>
>> On 27.02.20 01:37, Denis 'GNUtoo' Carikli wrote:
>>> This keeps the compatibility with the old bootcmd.
> [...]
>>> --- a/include/configs/tbs2910.h
>>> +++ b/include/configs/tbs2910.h
>>> @@ -8,6 +8,15 @@
>>>  #ifndef __TBS2910_CONFIG_H
>>>  #define __TBS2910_CONFIG_H
>>>
>>> +#define BOOT_TARGET_DEVICES(func) \
>>> +	func(MMC, mmc, 0) \
>>> +	func(MMC, mmc, 1) \
>>> +	func(MMC, mmc, 2) \
>>> +	func(SATA, sata, 0) \
>>> +	func(USB, usb, 0)
>>> +
>>> +#include <config_distro_bootcmd.h>
>>> +
>>>  #include "mx6_common.h"
>> I prefer to include the new section below the existing #include
>> "mx6_common.h". This way we keep that include at the usual place in
>> the beginning, while marking the config_distro_bootcmd.h as special
>> case.
> Is right under the "General configuration" comment a good place for
> that?
>
If you ask, maybe a new section
/* Distroboot */
before " Environment organization" would look nicer. Or can this even go
below BOOTENV in your new CONFIG_EXTRA_ENV_SETTINGS?

Soeren