[PATCH] spi: cadence_spi: Add octal and quad write support

Tan, Ley Foon ley.foon.tan at intel.com
Thu May 28 08:54:22 CEST 2020

> -----Original Message-----
> From: Pratyush Yadav <p.yadav at ti.com>
> Sent: Wednesday, May 27, 2020 9:07 PM
> To: Tan, Ley Foon <ley.foon.tan at intel.com>
> Cc: u-boot at lists.denx.de; Jagan Teki <jagan at amarulasolutions.com>; Ley
> Foon Tan <lftan.linux at gmail.com>; Vignesh Raghavendra
> <vigneshr at ti.com>; See, Chin Liang <chin.liang.see at intel.com>; Simon
> Goldschmidt <simon.k.r.goldschmidt at gmail.com>; Ang, Chee Hong
> <chee.hong.ang at intel.com>
> Subject: Re: [PATCH] spi: cadence_spi: Add octal and quad write support
> Hi Ley,
> On 22/05/20 03:53PM, Ley Foon Tan wrote:
> > In Commit d64077202158 ("spi: cadence_qspi: Move to spi-mem
> > framework") it removes setting to quad write bit by accident. This
> > commit restores it back and also adding checking for octal support.
> >
> > Fixes: d64077202158 ("spi: cadence_qspi: Move to spi-mem framework")
> I sent a patch to add Octal DTR support for this controller [0]. It should also
> fix this problem (check cadence_qspi_set_protocol()).
> [0]
> https://patchwork.ozlabs.org/project/uboot/patch/20200522124509.6901-
> 5-p.yadav at ti.com/

I have tried your patches with uboot/master, but it has compilation error below.

drivers/built-in.o: In function `spi_flash_std_remove':
drivers/mtd/spi/sf_probe.c:160: undefined reference to `spi_nor_remove'
drivers/mtd/spi/sf_probe.c:160:(.text.spi_flash_std_remove+0x10): relocation truncated to fit: R_AARCH64_JUMP26 against undefined symbol `spi_nor_remove'
drivers/built-in.o:(.rodata.spi_nor_ids+0x258): undefined reference to `mt35xu512aba_fixups'
drivers/built-in.o:(.rodata.spi_nor_ids+0x578): undefined reference to `s28hs512t_fixups'

Ley Foon

More information about the U-Boot mailing list