[PATCH v2 4/4] x86: apl: Add hex offsets for registers in FSP-S

Bin Meng bmeng.cn at gmail.com
Thu May 28 09:59:04 CEST 2020


On Thu, May 28, 2020 at 3:54 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Wed, May 27, 2020 at 7:42 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > When comparing hex dumps it is useful to see the offsets of the registers.
> > Add them in where they correspond to a multiple of 16.
> >
> > Possibly it would be useful to have a a command to output the FSP values
> > in human-readable form, making use of the fsp_bindings implementation.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v2:
> > - Correct the comment format
> > - Use 0x in register-offset comments
> >
> >  .../asm/arch-apollolake/fsp/fsp_s_upd.h       | 72 +++++++++++++++++++
> >  1 file changed, 72 insertions(+)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list