[PATCH v12 01/18] misc: add driver for the SiFive otp controller

[Pragnesh Patel]

Hi Simon,

>-----Original Message-----
>From: Simon Glass <sjg at chromium.org>
>Sent: 28 May 2020 08:38
>To: Pragnesh Patel <pragnesh.patel at sifive.com>
>Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Atish Patra
><atish.patra at wdc.com>; Palmer Dabbelt <palmerdabbelt at google.com>; Bin
>Meng <bmeng.cn at gmail.com>; Paul Walmsley <paul.walmsley at sifive.com>;
>Jagan Teki <jagan at amarulasolutions.com>; Anup Patel
><anup.patel at wdc.com>; Sagar Kadam <sagar.kadam at sifive.com>; rick
><rick at andestech.com>; Tero Kristo <t-kristo at ti.com>; Heiko Stuebner
><heiko.stuebner at theobroma-systems.com>; Finley Xiao <finley.xiao at rock-
>chips.com>; Adam Ford <aford173 at gmail.com>; Peng Fan
><peng.fan at nxp.com>; Eugen Hristev <eugen.hristev at microchip.com>
>Subject: Re: [PATCH v12 01/18] misc: add driver for the SiFive otp controller
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>Hi Pragnesh,
>
>On Mon, 25 May 2020 at 23:10, Pragnesh Patel <pragnesh.patel at sifive.com>
>wrote:
>>
>> Hi Simon,
>>
>> >-----Original Message-----
>> >From: Simon Glass <sjg at chromium.org>
>> >Sent: 26 May 2020 03:15
>> >To: Pragnesh Patel <pragnesh.patel at sifive.com>
>> >Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Atish Patra
>> ><atish.patra at wdc.com>; Palmer Dabbelt <palmerdabbelt at google.com>;
>Bin
>> >Meng <bmeng.cn at gmail.com>; Paul Walmsley
><paul.walmsley at sifive.com>;
>> >Jagan Teki <jagan at amarulasolutions.com>; Anup Patel
>> ><anup.patel at wdc.com>; Sagar Kadam <sagar.kadam at sifive.com>; rick
>> ><rick at andestech.com>; Tero Kristo <t-kristo at ti.com>; Heiko Stuebner
>> ><heiko.stuebner at theobroma-systems.com>; Finley Xiao
>> ><finley.xiao at rock- chips.com>; Adam Ford <aford173 at gmail.com>; Peng
>> >Fan <peng.fan at nxp.com>; Eugen Hristev
><eugen.hristev at microchip.com>
>> >Subject: Re: [PATCH v12 01/18] misc: add driver for the SiFive otp
>> >controller
>> >
>> >[External Email] Do not click links or attachments unless you
>> >recognize the sender and know the content is safe
>> >
>> >Hi Pragnesh,
>> >
>> >On Mon, 25 May 2020 at 01:34, Pragnesh Patel
>> ><pragnesh.patel at sifive.com>
>> >wrote:
>> >>
>> >> Added a misc driver to handle OTP memory in SiFive SoCs.
>> >>
>> >> Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
>> >> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>> >> Tested-by: Bin Meng <bmeng.cn at gmail.com>
>> >> Reviewed-by: Jagan Teki <jagan at amarulasolutions.com>
>> >> Tested-by: Jagan Teki <jagan at amarulasolutions.com>
>> >> ---
>> >>  drivers/misc/Kconfig      |   7 +
>> >>  drivers/misc/Makefile     |   1 +
>> >>  drivers/misc/sifive-otp.c | 275
>> >++++++++++++++++++++++++++++++++++++++
>> >>  3 files changed, 283 insertions(+)  create mode 100644
>> >> drivers/misc/sifive-otp.c
>> >
>> >Did you miss the change log here?
>>
>> For this series I am just updating the cover letter for change log.
>>
>> My apology for not updating the change log in every patch but I will
>> definitely take care this in future.
>>
>> For your reference,
>>
>> Changes in v12 for this patch:
>>
>> - Added necessary include files which are not part of common header
>> now
>>
>> drivers/misc/sifive-otp.c
>>         +#include <linux/bitops.h>
>>         +#include <linux/delay.h>
>
>OK...you can save yourself some work by using patman to send your patches.
>It handles putting the change-log from each commit into the cover letter.

Thanks, will give it a try in future.

>Regards,
>SImon