[PATCH 04/18] common: Drop net.h from common header

[Adam Ford]

On Mon, Apr 6, 2020 at 10:04 PM Simon Glass <sjg at chromium.org> wrote:
>
> Move this header out of the common header. Network support is used in
> quite a few places but it still does not warrant blanket inclusion.
>
> Note that this net.h header itself has quite a lot in it. It could be
> split into the driver-mode support, functions, structures, checksumming,
> etc.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>

This patch appears to break the USB OHCI on the da850-evm.

starting USB...
Bus usb at 200000: Port not available.
Bus usb at 225000: USB OHCI 1.0
scanning bus usb at 225000 for devices... ERROR: CTL:TIMEOUT

The CTL:TIMEOUT is part of drivers/usb/host/ohci-hcd.c

I can go back and forth and the issue appears very repeatable.

A working state looks like:

starting USB...
Bus usb at 200000: Port not available.
Bus usb at 225000: USB OHCI 1.0
scanning bus usb at 225000 for devices... 2 USB Device(s) found
       scanning usb for storage devices... 1 Storage Device(s) found


I generated drivers/usb/host/ohci-hcd.i files between the working and
non-working versions to see
if/what is different, but they are different.

It's too large of a patch to just do a revert on this commit at
master, because of many of the dependent changes that have been made
after that. I am open for ideas on what to do to regain the broken USB
functionality.

thanks,

adam
> ---
>