[PATCH 2/2] dma-mapping: Add header file for ARCH_DMA_MINALIGN

Simon Glass sjg at chromium.org
Sun May 31 16:10:46 CEST 2020


Hi Tom,

On Sat, 30 May 2020 at 11:27, Tom Rini <trini at konsulko.com> wrote:
>
> On Sat, May 30, 2020 at 01:20:10PM -0400, Tom Rini wrote:
> > On Sat, May 30, 2020 at 10:29:04AM -0600, Simon Glass wrote:
> >
> > > This is defined in the asm/cache.h header file. Update this header file to
> > > include it.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> >
> > Reviewed-by: Tom Rini <trini at konsulko.com>
> >
> > There's also drivers/usb/host/ohci.h and lib/elf.c which also reference
> > ARCH_DMA_MINALIGN without also logically pulling it in, I'll fix those.
>
> Dunno how I missed that 1/2 is what fixed that one, sorry.  And
> lib/elf.c is a problem in theory but would be a fail to build if not
> pulled in logically so I'll leave it be for now.

Yes I think the issue is the #ifdef default. Probably that should be
removed at some point as it is quite risky to have that sort of thing.

Regards,
Simon


More information about the U-Boot mailing list