[PATCH V2] net: smc911x: Automatically Update ethaddr with MAC

Marek Vasut marex at denx.de
Thu Oct 1 19:48:32 CEST 2020


On 10/1/20 4:09 PM, Tom Rini wrote:
> On Tue, Aug 18, 2020 at 08:19:02AM -0500, Adam Ford wrote:
> 
>> The ethernet controller can read the MAC from EEPROM and display it,
>> but if ethaddr is not set, the ethernet is still unavailable.
>>
>> This patch checks will automatically set the MAC address if it has
>> not already been set.
>>
>> Signed-off-by: Adam Ford <aford173 at gmail.com>
>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> 
> Applied to u-boot/next, thanks!

Note that this breaks every single setup where smc911x is not primary
ethernet. On systems where smc911x is secondary ethernet, you need to
set eth1addr and so on, so please do fix that.

Also, this kind of ethXaddr update should happen in the ethernet core
instead, drivers shouldn't really modify environment, no ?


More information about the U-Boot mailing list