[PATCH] mailbox: stm32_ipcc: Convert to use APIs which support live DT
Patrice CHOTARD
patrice.chotard at st.com
Fri Oct 2 11:42:35 CEST 2020
Hi Patrick
On 9/9/20 5:48 PM, Patrick Delaunay wrote:
> Use ofnode_ or dev_ APIs instead of fdt_ and fdtdec_ APIs so that the
> driver can support live DT.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
> drivers/mailbox/stm32-ipcc.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c
> index b8bf356b4a..81a4115986 100644
> --- a/drivers/mailbox/stm32-ipcc.c
> +++ b/drivers/mailbox/stm32-ipcc.c
> @@ -101,9 +101,8 @@ static int stm32_ipcc_probe(struct udevice *dev)
> {
> struct stm32_ipcc *ipcc = dev_get_priv(dev);
> fdt_addr_t addr;
> - const fdt32_t *cell;
> struct clk clk;
> - int len, ret;
> + int ret;
>
> debug("%s(dev=%p)\n", __func__, dev);
>
> @@ -114,14 +113,12 @@ static int stm32_ipcc_probe(struct udevice *dev)
> ipcc->reg_base = (void __iomem *)addr;
>
> /* proc_id */
> - cell = dev_read_prop(dev, "st,proc_id", &len);
> - if (len < sizeof(fdt32_t)) {
> + ret = dev_read_u32_index(dev, "st,proc_id", 1, &ipcc->proc_id);
> + if (ret) {
> dev_dbg(dev, "Missing st,proc_id\n");
> return -EINVAL;
> }
>
> - ipcc->proc_id = fdtdec_get_number(cell, 1);
> -
> if (ipcc->proc_id >= STM32_MAX_PROCS) {
> dev_err(dev, "Invalid proc_id (%d)\n", ipcc->proc_id);
> return -EINVAL;
Reviewed-by: Patrice Chotard <patrice.chotard at st.com>
Thanks
More information about the U-Boot
mailing list